Skip to content

Add complex data type support to live watch #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 27, 2025
Merged

Add complex data type support to live watch #592

merged 11 commits into from
Oct 27, 2025

Conversation

@omarArm
Copy link
Collaborator

@omarArm omarArm commented Oct 27, 2025 •
edited
Loading

Fixes

Changes

  • Added support to complex data types in Live Watch
  • Added custom icon to view container

P.S. So far I don't know how to customise the view container icon depending on VSCode's theme. However, I added the two icons provided by @KeilChris in the repo until I find a way

Screenshots

image image

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@qltysh
Copy link

qltysh bot commented Oct 27, 2025 •
edited
Loading

Diff Coverage: The code coverage on the diff in this pull request is 93.5%.

Total Coverage: This PR will increase coverage by 0.13%.

File Coverage Changes
Path File Coverage Δ Indirect
src/features/cpu-states/cpu-states.ts 0.1
src/views/live-watch/live-watch.ts 1.2
🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@omarArm omarArm requested a review from jreineckearm October 27, 2025 12:50
@jreineckearm
Copy link
Collaborator

jreineckearm commented Oct 27, 2025

P.S. So far I don't know how to customise the view container icon depending on VSCode's theme. However, I added the two icons provided by @KeilChris in the repo until I find a way

IIUC, you only need a single monochrome SVG icon for view containers. Coloring should be adjusted by VS Code automatically.
However, view icons require both dark and light theme. Please add them to cmsis-debugger.liveWatch as discussed before. I still see the yellow schema warning squiggles in package.json because icons are missing.

jreineckearm
jreineckearm reviewed Oct 27, 2025
View reviewed changes
jreineckearm
jreineckearm reviewed Oct 27, 2025
View reviewed changes
@jreineckearm
Copy link
Collaborator

jreineckearm commented Oct 27, 2025

However, view icons require both dark and light theme. Please add them to cmsis-debugger.liveWatch as discussed before. I still see the yellow schema warning squiggles in package.json because icons are missing.

My bad, dark vs light theme is only used for command icons/

jreineckearm
jreineckearm reviewed Oct 27, 2025
View reviewed changes
jreineckearm
jreineckearm approved these changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@jreineckearm jreineckearm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the swift response to my feedback! Functionality works nicely!

One minor note for a later increment: you can expand node children while the CPU is running. But no new children appear. I think in theory you should be able to fetch the children if things are running. But I see this as a minor defect that can be addressed in a separate PR. Please make a note of it, I think view discoverability and context menu are the next things to look into.

@jreineckearm jreineckearm merged commit bd3fcbd into main Oct 27, 2025
15 checks passed
@jreineckearm jreineckearm deleted the addComplexDataTypeSupportToLiveWatch branch October 27, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreineckearm jreineckearm jreineckearm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@omarArm @jreineckearm